Wc/snap to terrain - CsvSpawner: Make "snap to terrain" based on collision layer. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pijaro
requested changes
Oct 10, 2024
|
I've copied the code from version I had in other repo. |
michalpelka
reviewed
Oct 17, 2024
michalpelka
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Code is not fromated:
And there is a problem with missing headers
/home/michalpelka/github/ROSConDemo2023WorkDir/robotec-o3de-tools/Gems/CsvSpawner/Code/Source/CsvSpawner/CsvSpawnerUtils.h:63:3: error: use of undeclared identifier 'AzPhysics'
AzPhysics::CollisionLayer m_selectedCollisionLayer; //!< To which collision layer this target will be attached
|
Please fix compilation error: |
Signed-off-by: wc-robotec <[email protected]>
Signed-off-by: wc-robotec <[email protected]>
Signed-off-by: wc-robotec <[email protected]>
|
Fixed missing header error and added Az_Asert. |
michalpelka
requested changes
Oct 28, 2024
Signed-off-by: Michał Pełka <[email protected]>
michalpelka
approved these changes
Oct 28, 2024
Signed-off-by: wc-robotec <[email protected]>
Signed-off-by: wc-robotec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added CollisionLayer to AssetConfig.
When Place On Terrain is Enabled - then a layer can be chosen to which object will be attached on spawn.